Merged
Conversation
Fix the dtype of the argparse variable `NUM_POINTS` from float to int. If `NUM_POINTS` is a float, indexing arrays with it will fail.
Additionally to the centered moving average and the cumulative average, also plot the total average to the plot.
Replace the option `--num-points` by the options `--cutout-start` and `--cutout-end`. Before, users could only specify how many data points to show in the cutout plot from the end of the data series. Now, the users can specify a start and end point for the cutout plot.
Set the handlelength in legends to 1.8. Before it was the default value of 2.0. This leads to a nicer representation of dashed lines in legends.
Decrease the handlelength for small legends to from 1.6 to 1.35. This leads to a nicer representation of dashed lines in small legends and additionally shrinks the legend further.
github-actions
bot
added
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and Update
plot_energy_dist.pyRelated issue(s)
The type of the
argparseinput variableNUM_POINTSwas float but has to by int, because it is used for indexing arrays.Type of change
Proposed changes
--num-pointsoption entirely and replace it by the options--cutout-startand--cutout-endwhich allows the users to specify a start and end point for the cutout plot instead of just plotting the last--num-pointsdata points.plot.py]: Decrease the handlelength for small legends to from 1.6 to 1.35. This leads to a nicer representation of dashed lines in small legends and additionally shrinks the legend further.PR checklist