Conversation
…e_subarrays` Refactor the function `mdtools.numpy_helper_functions.split_into_consecutive_subarrays`: * Rename the function to `mdtools.numpy_helper_functions.split_into_contig_seqs`. * Remove the argument `debug`. Instead always check the input arguments. * Change the default of the argument `sort` from `True` to `False`. * Add the argument `step_tol` that allows to provide a tolerance value for the step size of the contiguous sequences. * Add the argument `return_ix` that allows to return the indices where the input array was split to create the subarrays. * Add examples to the docstring.
Create a new function `mdtools.numpy_helper_functions.get_const_seqs` that extracts all sequences of constant values from an array.
Create a new function `mdtools.numpy_helper_functions.find_const_seq_n` that finds the first sequence of at least n constant values in an array.
Create a new function `mdtools.numpy_helper_functions.find_const_seq_long` that finds the longest sequence of constant values in an array.
github-actions
bot
added
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create functions to find sequences of constant values in NumPy arrays
Type of change
Proposed changes
Refactor the function
mdtools.numpy_helper_functions.split_into_consecutive_subarrays:mdtools.numpy_helper_functions.split_into_contig_seqs.debug. Instead always check the input arguments.sortfromTruetoFalse.step_tolthat allows to provide a tolerance value for the step size of the contiguous sequences.return_ixthat allows to return the indices where the input array was split to create the subarrays.Create a new function
mdtools.numpy_helper_functions.get_const_seqsthat extracts all sequences of constant values from an array.Create a new function
mdtools.numpy_helper_functions.find_const_seq_nthat finds the first sequence of at leastnconstant values in an array.Create a new function
mdtools.numpy_helper_functions.find_const_seq_longthat finds the longest sequence of constant values in an array.PR checklist