Skip to content

Fix consistency checks of the Kaplan-Meier Estimator#199

Merged
andthum merged 2 commits intomainfrom
fix/src/mdtools/dtrj/kaplan-meier/consistency-checks
Nov 17, 2023
Merged

Fix consistency checks of the Kaplan-Meier Estimator#199
andthum merged 2 commits intomainfrom
fix/src/mdtools/dtrj/kaplan-meier/consistency-checks

Conversation

@andthum
Copy link
Owner

@andthum andthum commented Nov 17, 2023

Fix consistency checks of the Kaplan-Meier Estimator

Type of change

  • Change of core package.
  • Change of scripts.
  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Proposed changes

  • Function mdtools.dtrj.kaplan_meier: The first element of the returned survival-function array can not only be zero but also NaN.
  • Function mdtools.dtrj.leave_prob: The first element of the returned leave-probability array can not only be zero but also NaN.

PR checklist

  • I followed the guidelines in the Developer's guide.
  • New/changed code is properly tested.
  • [~] New/changed code is properly documented.
  • The CI workflow is passing.

The first element of the returned leave-probability array can also be
NaN.
The first element of the returned survival-function array can also be
NaN.
@github-actions github-actions bot added bugfix Pull requests that fix a bug patch Change that results in a new patch version labels Nov 17, 2023
@andthum andthum merged commit 833f148 into main Nov 17, 2023
@andthum andthum deleted the fix/src/mdtools/dtrj/kaplan-meier/consistency-checks branch November 17, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull requests that fix a bug patch Change that results in a new patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant