Merged
Conversation
* Do not run the workflow on pull requests that neither change the
code nor the docs (add `path-ignore` option).
* Use caching to speed up the workflow.
* Check code formatting with black (only for already formatted files).
* Lint the code only once using the highest target Python version of
MDTools (instead of linting the code with all target Python
versions).
* Use `setup.cfg` to configure `flake8` (instead of doing all the
configure on the command line).
* Test the code with all target Python versions and operating systems.
* Do not cancel all matrix jobs if one job fails (`fail-fast: false`).
* Add a test installation of MDTools to the test suite.
* Add a test build of the documentation to the test suite.
* Add doctest to the test suite.
* Scan the code for security vulnerabilities with CodeQL.
* Add `.github/dependabot.yml` to watch for updated Python packages
or GitHub Actions.
* Remove `requirements_python3.8.10.txt`, because Dependabot should
only inspect requirements.txt for version updates and not
`requirements_python3.8.10.txt`. Additionally,
`requirements_python3.8.10.txt` should not show up in GitHub's
dependency graph. Furthermore, `requirements_python3.8.10.txt` is
not needed anymore, because our CI workflow now checks whether
MDTools can be installed on all target operating systems with all
target Python versions. Thus, we know in advance, if any changes
would break the installability of MDTools and we do not need a
backup requirements file anymore.
Change indentation level from four to two spaces in accordance with the YAML conventions.
* Add `VENV/` * Add `docs/build/`
Format docstring of `mdtools/version.py` to adhere to flake8.
* Read authors and maintainer from `mdtools/_metadata.py`. * Update PyPi classifiers about supported operating systems. * Update keywords. * Format `setup.py` with black.
* Raise errors if `__author__`, `__maintainer__` or `__credits__`
contain duplicates or are not ordered alphabetically.
* Format with black
Add badge "Code style black" to `README.rst` and `docs/source/index.rst`
* Replace a wrong space character (bad char) by a proper space
character
ezavod
reviewed
Jul 12, 2021
Collaborator
ezavod
left a comment
ezavod
left a comment
There was a problem hiding this comment.
Awesome, this is all very cool. I mostly have some questions to better understand the new workflow.
Remove `__init__.py` from list of ignored files
Apply proposed changes: Remove white spaces from author, maintainer and credits list before checking alphabetic order.
ezavod
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposing in this pull request:
VENV/and docs/build/to.gitignore`.