Fix #843: do not drop focus from message field on send #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
requested changes
Apr 12, 2025
Owner
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
LGTM, can you just amend the commit message to be something like:
fix(gnome): do not drop focus from message field on send
closes #843
Contributor
Author
|
Will do!
…On Sat, Apr 12, 2025, 13:37 Andy Holmes ***@***.***> wrote:
***@***.**** requested changes on this pull request.
LGTM, can you just amend the commit message to be something like:
fix(gnome): do not drop focus from message field on send
closes #843
—
Reply to this email directly, view it on GitHub
<#846 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIMDM6FRUKDWS7NDFHUVL2ZF2RDAVCNFSM6AAAAAB3AFNTXCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRSGI2TAMJUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
closes andyholmes#843 This removes the changes to sensitivity during async message send. Which dropped focus as a side effect.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by removing the any changes to sensitivity. Which drop focus as a side effect.