Closed
Conversation
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
victordmontero
requested changes
May 15, 2024
Collaborator
victordmontero
left a comment
victordmontero
left a comment
There was a problem hiding this comment.
Good job overall but I have some concerns:
- Reverting work done in other PRs, that were previously accepted by yourself.
- Added a script to clang format files, but not using it on the files. If you already added it, why not using?
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Co-authored-by: Victor D. Montero <victordanielmontero@gmail.com>
Collaborator
|
Squash those commits. It'll be better for everybody |
Owner
Author
I need to check and Re-pull |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WindowManager, SDLWRapper PIMPL classes , MErge new Events a so on.