Skip to content

Conversation

@DarkArc
Copy link

@DarkArc DarkArc commented Oct 10, 2017

There's an issue right now, where if the socket wrangler is unable to connect, it will occasionally cause a digest error, this change protects against that situation ensuring no exception is raised.

This method effectively exists in the angular websockets package, however, it is not currently available in the scope of the socket wrangler, and would require a fair amount of restructuring to get to.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 68.122% when pulling e2e521f on SynergyDataSystems:hotflix/digest-issue into 1f00de9 on angular-actioncable:master.

var _live= false;
var _connecting= false;
var _reconnectTimeout= false;
var preConnectionCallbacks= [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, got pulled in from the other branch somehow 😅

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 67.982% when pulling 84679e1 on SynergyDataSystems:hotflix/digest-issue into 1f00de9 on angular-actioncable:master.

@b264 b264 merged commit 06eb19b into angular-actioncable:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants