template/app/typings.json error?

[JeremyMarshall]

• I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.

Item	Version
generator-angular-fullstack	x.x.x
Node	3.7.4
npm	4.2.4
Operating System	OS X 10

Item	Answer
Transpiler	/ TypeScript
Markup	HTML / Jade
CSS	CSS / LESS / SCSS / Stylus
Router	ngRoute / ui-router
Build Tool	Grunt / Gulp
Client Tests	Jasmine / Mocha
DB	MongoDB / SQL
Auth	Y / N

In templates/app/typings(ts).json if its possible to have mocha and jasmine defined then the generated json is invalid as there is a missing comma
Adding a trailing comma is also invalid in my setup for parsing the json
This is a problem because I'm looking to add all the npm dependencies in for a docker image and planning to process the json here to generate the requirements

[Koslun]

You choose between mocha and jasmine, so no, don't think it is invalid once it's been generated.

Could always just add a trailing comma to both and move them up ahead of the other always present typings defined if that was the case, but as stated don't think it's necessary.

Are you planning on processing the generator itself?

[JeremyMarshall]

I was thinking of processing it to create the base docker image. That will have all the npm dependencies baked in. So the template package.json has the right versions. At the moment it's a shell script but could be a commit hook.

And yes I moved one of the other dependencies down and added commas. I'll add it into the PR

Sent from my iPhone

On 1 Jun 2016, at 11:30 PM, Adam notifications@github.com wrote:

You choose between mocha and jasmine, so no, don't think it is invalid once it's been generated.

Could always just add a trailing comma to both and move them up ahead of the other always present typings defined if that was the case, but as stated don't think it's necessary.

Are you planning on processing the generator itself?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.