Skip to content

Conversation

@Awk34
Copy link
Member

@Awk34 Awk34 commented Sep 11, 2015

No description provided.

app/generator.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this.rootGeneratorVersion() instead of version.

@kingcody
Copy link
Member

And a rebase.

@Awk34
Copy link
Member Author

Awk34 commented Sep 11, 2015

done

@kingcody
Copy link
Member

Thanks

@kingcody
Copy link
Member

One question, why not add it as a top level property, instead of putting it in filters?

@kingcody
Copy link
Member

this.config.set('generatorVersion', this.rootGeneratorVersion())

@Awk34
Copy link
Member Author

Awk34 commented Sep 11, 2015

..oversight, I'll change

kingcody added a commit that referenced this pull request Sep 11, 2015
feat(gen): Show version in console, add to .yo-rc.json
@kingcody kingcody merged commit 83d7c1d into canary Sep 11, 2015
@kingcody kingcody deleted the log-gen-version branch September 12, 2015 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants