Skip to content

Conversation

@royeeshemesh
Copy link

changed the location of the navbar component snippet to be only in the index.html file above ui-view / ng-view placeholder to load it only once and not in every route's html file.

@lirantal
Copy link
Contributor

+1 for this performance improvement

@kingcody
Copy link
Member

kingcody commented Jan 3, 2016

Thanks for the PR @flexpert, your changes LGTM. However, this branch needs to be rebased on canary before it can be merged. Also, while rebasing, would you mind updating the commit message to follow the contributing.md guidelines? Thanks again.

@Awk34
Copy link
Member

Awk34 commented Jan 9, 2016

I have made #1543 with updated code

@Awk34 Awk34 closed this Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants