Skip to content

Conversation

@jeef3
Copy link
Contributor

@jeef3 jeef3 commented Nov 21, 2013

This separates the watch into two; client and server. Client-side changes don't require a node restart, so they only trigger a LiveReload.

The livereload: true in the express target is optional. You could decide that server-side changes don't require a reload, but there is a use case for leaving it in too, so I've left it.

@DaftMonk
Copy link
Member

Looks good. Can you rename the commit to follow the guidelines? https://github.com/DaftMonk/generator-angular-fullstack/blob/master/contributing.md e.g: feat(app): Separate client and server watchers

@jeef3
Copy link
Contributor Author

jeef3 commented Nov 21, 2013

Sure, apologies for that.

@DaftMonk
Copy link
Member

Cool, thanks.

DaftMonk added a commit that referenced this pull request Nov 21, 2013
Separate client and server watchers
@DaftMonk DaftMonk merged commit 9f61499 into angular-fullstack:master Nov 21, 2013
@jeef3 jeef3 deleted the separate-watchers branch November 21, 2013 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants