Skip to content

fix: rm WeakMap, we can't use it for key with type string #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SethDavenport merged 1 commit into from
Mar 27, 2017
Merged

fix: rm WeakMap, we can't use it for key with type string #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions source/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export abstract class State {
() => Array.prototype.slice.call(object, 0)
);
}
else if (object instanceof WeakMap || object instanceof Map) {
else if (object instanceof Map) {
return metaOperations(
// Update map key
(parent, key: number | string, value: K) => {
Expand All @@ -217,9 +217,7 @@ export abstract class State {
},

// Clone
() => object instanceof WeakMap
? new WeakMap<string, any>(<any> object)
: new Map<string, any>(<any> object)
() => new Map<string, any>(<any> object)
);
}
else if (object instanceof WeakSet || object instanceof Set) {
Expand Down