Update so it works with Reactive forms #27
Conversation
|
@SethDavenport Not sure if you are the right person to bug but what needs to happen to get this reviewed and brought in? |
|
Sorry for the delay on this - I actually haven't been super involved with angular-redux/form - I'm mostly the store and example-app guy. Unfortunately /form needs a new maintainer, and possibly a re-think, as you may have noticed. My personal take is that we never intended to support the formBuilder stuff; in practice template-driven forms are much more declarative and therefore preferable. @danielfigueiredo @clbond any thoughts on this change? It seems reasonable to me, but you have more experience with complex forms in Angular than I do. |
source/connect-base.ts
Outdated
| } | ||
| else{ | ||
| formElement = this.form.control; | ||
| } |
|
|
||
| #### Reactive Forms | ||
| The value in "connect" attribute is the value that will show up in the Redux store. The formGrup value is the name of hte object in your code that represents the form group. | ||
|
|
source/module.ts
Outdated
| exports: [ | ||
| Connect, | ||
| ConnectTemplateDirective, | ||
| ConnectReactiveDirective, |
There was a problem hiding this comment.
This represents a breaking API change - is there any way we can avoid this?
There was a problem hiding this comment.
I don't see how, as the source of the form has now changed between the two. Maybe we can keep the template class named "connect" so that class stays the same for people plugged in for template driven forms? Then, at least to me, the name of the class is less declarative on what it does but may be an option.
There was a problem hiding this comment.
No need for a breaking change.
ConnectandReactiveConnect
are fine, too.
In @angular/forms its similar:
FormsModuleReactiveFormsModule
There was a problem hiding this comment.
yup I'm cool with that suggestion.
There was a problem hiding this comment.
Updated PR based on this conversation to align.
|
Give @angular-redux/form@6.5.0 a whirl and let me know. |
|
Still have never gotten this to work. :/ Not once have I even seen a form show up in my state. Are the docs up to date? |
3 participants
Address issue #22
Tested this locally with the code base that triggered the creation of this issue. Works for template and reactive. Locally the tests will not run but they also do not run with the main GIT master branch so seems to be a local issue. Please review and provide any feedback.