This repository was archived by the owner on Jan 26, 2024. It is now read-only.
fixes ngAdd schematic: options.project was always undefined #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, gentlemen,
I'm pretty sure that the signature of the
ngAddschematic was broken. The affected code was directly copied from ngx-gh, so later on we might want to double-check that nobody else copied that error, too. In the end the value ofoptions.projectwas always undefined. This was reported in #5.BEFORE:
AFTER
I also didn't understand the original test:
https://github.com/mgechev/ngx-gh/blob/5088488a50af7550eb6b5b0dfcfac4ade6a61085/ng-add.spec.ts#L36-L47
Why should one installation override the next one in case of multiple projects? In the current implementation, both simply changes remain.
@mgechev could you please review this and tell me if I'm on the right track?
FYI @dianjuar