fixes issue #1436 & #1255 #1441
Conversation
|
@wrummler |
|
Ready for review. |
correctly fixes issue angular-ui#1255
There was a problem hiding this comment.
Is this going to have performance implications?
There was a problem hiding this comment.
Probably, but watchCollection was not firing since the childScope is essentially detached from the model the only way we can get the update is via models. So if we want simple changes like visible and editable they get dropped. But if the user knows to replace the model object instance then watchCollection should catch it.
I guess we could set it up to watchCollection or watch based on some setting. I didn't really care to go that deep; and instead just fix the issue.
There was a problem hiding this comment.
Alright, I'd say let's throw a comment in there with "@todo" or something so we know where this is easily in the future and that the decision was conscious. That way if folks try to complain in the future, we can point them to the place to fix it.
|
See comments, otherwise, LGTM. |
|
@cthrax comments added |
|
👍 |
There was a problem hiding this comment.
This is where setVisible and other attributes were getting borked. As the child.scope never had the correct values.
@wrummler
2 participants
No description provided.