Skip to content
This repository was archived by the owner on Feb 19, 2025. It is now read-only.

Conversation

@jaroslawZawila
Copy link

Hello,
I have experienced the same problem like the one in issue #325. This is my fix to it.

@ProLoser
Copy link
Member

You only modified the build file when you are supposed to modify the source file and not commit the build files.

@jaroslawZawila
Copy link
Author

Cool, I did it because I could not find a source file. Maybe is a stupid question but where could I find sources ??

@petebacondarwin
Copy link
Member

 handling connectWith options correctly
@jaroslawZawila
Copy link
Author

Hey, I have done it in correct way this time I hope so :)

@ProLoser
Copy link
Member

I'll merge this in on my next opportunity, but if you can, can you remove your changes to the build file? Just the Coffee file. And if possible, it would help if you can add some tests.

After this merge I will be changing the code from COFFEE to JS to keep the entire project consistent.

removed changes to build file
@jaroslawZawila
Copy link
Author

I removed changes to build file and working on the test right now but it could take some time to accomplish it.

@martin-wintz
Copy link

Hmm, well, I'm new to Github and Angular and I was looking forward to making my first contribution. I guess I now know to make a pull request and not submit an issue if I find the solution to a problem.

@ProLoser
Copy link
Member

@maybiusstrip

Feel free to do both :)

A pull request is also an issue:
https://github.com/angular-ui/angular-ui/pull/340
https://github.com/angular-ui/angular-ui/issues/340

But if you want you can reference an existing issue by just entering #340 in your commit or description and Github will autolink.

ProLoser added a commit that referenced this pull request Jan 30, 2013
@ProLoser ProLoser merged commit 0d86357 into angular-ui:master Jan 30, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants