This repository was archived by the owner on Sep 8, 2020. It is now read-only.
feat(config): always call the global onLoad handler
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: build is failing for the reasons outlined in #77, it's not a result of this PR. |
|
Hi @marshall007 |
marshall007
force-pushed
the
global-load
branch
from
92b5569 to
c7a03dc
Compare
|
@douglasduteil yep, done! |
|
Thanks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I wanted to setup Ace in the
uiAceConfig.ace.onLoadhandler because I was setting a lot of "advanced" options anyway. I then needed to configure hotkeys on individual Ace instances, which wiped out the globalonLoadhandler.With this PR, the global
onLoadhandler is always called first followed by the instanceonLoadif specified.