Column reordering does not work if pinning is enabled

[somelinguist]

Column reordering does not work if enablePinning is set to true:

http://plnkr.co/edit/xbbp7e?p=preview

Also, even if enablePinning is set to false, if an individual column is marked as pinned, column reordering has bugs:

http://plnkr.co/edit/rjwola?p=preview

[orneryd]

this looks fixed in commit ac7ac57

[orneryd]

http://plnkr.co/edit/rFqbxe?p=preview

[somelinguist]

I tried your Plunker in both Firefox and Chrome and I'm still seeing both problems.

There's no reordering at all if enablePinning is set to true. Is this intentional?

If enablePinning is false but one of the columns has pinned=true, you can reorder most of the columns, but if you try to drag one over top of the column with pinned=true, the non-pinned column disappears, leaving a blank column to the right of the pinned one.

Of course, ideally, you would never have a column with pinned=true if enablePinning=false, but I can think of buggy situations where it might happen (having a pinned column and then disabling pinning).

Thanks for your help!

[orneryd]

yes, for now if a column is pinned you cannot move it until it is de-pinned.

what we should do is ensure that pinning is set to false if not enabled.

On Mon, Mar 18, 2013 at 5:20 PM, somelinguist notifications@github.comwrote:

I tried your Plunker in both Firefox and Chrome and I'm still seeing both
problems.

There's no reordering at all if enablePinning is set to true. Is this
intentional?

If enablePinning is false but one of the columns has pinned=true, you can
reorder most of the columns, but if you try to drag one over top of the
column with pinned=true, the non-pinned column disappears, leaving a blank
column to the right of the pinned one.

Of course, ideally, you would never have a column with pinned=true if
enablePinning=false, but I can think of buggy situations where it might
happen (having a pinned column and then disabling pinning).

Thanks for your help!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/241#issuecomment-15090541
.

-Tim Sweet

[orneryd]

I just made it so the behavior cannot happen

21bfb93

On Mon, Mar 18, 2013 at 5:23 PM, Timothy Sweet timothyswt@gmail.com wrote:

yes, for now if a column is pinned you cannot move it until it is
de-pinned.

what we should do is ensure that pinning is set to false if not enabled.

On Mon, Mar 18, 2013 at 5:20 PM, somelinguist notifications@github.comwrote:

I tried your Plunker in both Firefox and Chrome and I'm still seeing both
problems.

There's no reordering at all if enablePinning is set to true. Is this
intentional?

If enablePinning is false but one of the columns has pinned=true, you can
reorder most of the columns, but if you try to drag one over top of the
column with pinned=true, the non-pinned column disappears, leaving a blank
column to the right of the pinned one.

Of course, ideally, you would never have a column with pinned=true if
enablePinning=false, but I can think of buggy situations where it might
happen (having a pinned column and then disabling pinning).

Thanks for your help!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/241#issuecomment-15090541
.

-Tim Sweet

-Tim Sweet

[somelinguist]

Thanks for the clarification and the fix!

[AdamCraven]

This issue it back again, no longer works in latest. http://plnkr.co/edit/O2N1Ce?p=preview

[michaelpnash]

Confused why this is closed... column re-ordering doesn't appear to work at all with HEAD?

[roblarsen]

You'd need to build the project. I haven't updated the ng-grid files in HEAD. I just merged the changes into the src files. I've been trying to get my head around when we were going to do a release.

[michaelpnash]

Rob:

Good stuff, thanks!

Mike

On Fri, Oct 25, 2013 at 8:43 AM, Rob Larsen notifications@github.comwrote:

You'd need to build the project. I haven't updated the ng-grid files in
HEAD. I just merged the changes into the src files. I've been trying to get
my head around when we were going to do a release.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/241#issuecomment-27097898
.

Michael Nash
JGlobal Limited
http://jglobal.com
Software Craftsmanship Applied