Fix(infiniteScroll): fix #2730, fix #2827, BREAKING changes #3085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NG changes Substantial refactor of infinite scroll. Provides new functionality, a much more detailed tutorial, and removes the code that crept into core in angular-ui#2730 (which I merged when I shouldn't have). Clarifies the handling, removes a viewPort directive that was unnecessary, makes the handling for scroll up and down consistent. Strictly speaking the API hasn't changed, but there are some new settings and the default behaviour has subtly changed in that scrollUp isn't enabled by default. This should be more logical to users, but probably does require a review of the tutorial and API.
Contributor
Author
|
@mloutraris-ge, @novice3030: there are significant changes to infinite scroll in here. It would be good to get a review and check it's still working well for you. Note that there are some API changes that probably don't impact anyone but might - mostly in terms of default behaviour. @swalters: I've stripped the infinite scroll stuff out of core - this impacts the ui-grid directive and the gridFactory. I suspect you are touching these in your scroll refactoring, so worth noting that they go away - you can safely delete them. |
Contributor
|
We will check it out and let you know. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantial refactor of infinite scroll. Provides new functionality, a much more
detailed tutorial, and removes the code that crept into core in #2730 (which I merged
when I shouldn't have). Clarifies the handling, removes a viewPort directive that was
unnecessary, makes the handling for scroll up and down consistent.
Strictly speaking the API hasn't changed, but there are some new settings and the
default behaviour has subtly changed in that scrollUp isn't enabled by default. This
should be more logical to users, but probably does require a review of the tutorial and API.