Skip to content

Fix issue #581#991

Closed
getuliojr wants to merge 13 commits into
angular-ui:masterfrom
getuliojr:master
Closed

Fix issue #581#991
getuliojr wants to merge 13 commits into
angular-ui:masterfrom
getuliojr:master

Conversation

@getuliojr
Copy link
Copy Markdown

Fix the problem of the ng-grid not showing when inside of a tab or a div that is hidden. The problem surged because of the class ng-hide that had an !important in its class. Fixed the problem by adding an important at the element when getting real width.

The same patch updated in the debug version. It solves the problem of ng-grid not showing correctly when it is in hidden parents like tabs or modals.
update do repo
Fix the problem of the ng-grid not showing when inside of a tab ou div that is hidden. The problem surged because of the class ng-hide that had an !important in its class. Fixed the problem by adding an important at the element when getting real width.
@getuliojr
Copy link
Copy Markdown
Author

Only "Fix ng-grid not showing when on hidden elements …" (d7737b1) is needed to fix the issue. I guess I pr some itens more from the last time I contributed.

@AlJohri
Copy link
Copy Markdown

AlJohri commented Feb 13, 2014

Thanks for doing this! Will test it out soon.

@AlJohri
Copy link
Copy Markdown

AlJohri commented Feb 21, 2014

It seems to not be working for me. I have a div hidden using the ng-show directive.

browse.html

<div class="row" ng-show="currentFilter.topic">
    <div class="col-sm-7">
        <div class="gridStyle" ng-grid="gridOptions"></div>
        <p>{{status_bar}}</p>                     
    </div>
</div>

browser.js

  $scope.filterOptions = { filterText: '', useExternalFilter: true };
  $scope.pagingOptions = { pageSizes: [20], pageSize: 20, currentPage: 1 };
  $scope.sortInfo = { fields: ['date'], directions: ['asc'] };
  $scope.dateOptions = { changeYear: true, changeMonth: true, yearRange: '1900:-0' };
  $scope.mySelections = [];
  $scope.gridOptions = {
    data: 'speeches',
    columnDefs: [
      {field: 'speech_id', displayName: 'ID', width: '10%'},
      {field: 'title', displayName: 'Title', width: '61%'},
      {field: 'speaker_state', displayName: 'State', width: '7%'},
      {field: 'speaker_party', displayName: 'Party', width: '7%'},
      {field: 'date', displayName: 'Date', width: '15%'}
    ],
    enablePaging: true,
    pagingOptions: $scope.pagingOptions,
    filterOptions: $scope.filterOptions,
    totalServerItems: 'total',
    useExternalSorting: true,
    keepLastSelected: false,
    multiSelect: false,
    i18n: 'en',
    jqueryUITheme: false,
    sortInfo: $scope.sortInfo,
    showFooter: true,
    selectedItems: $scope.mySelections
  };

bower.json

    "ng-grid": "git://github.com/getuliojr/ng-grid.git#master",

@getuliojr
Copy link
Copy Markdown
Author

I can take a look on your code next week, today I am working in a way for each row In ng-grid to have different heights to acommodate whole cell content. Kind bothers me To have fixed size rows. Might do a pull request today fixing it.

Removing information about grid height so it can be generated dyanmicaly
This is a hack a best solution would be implementing max-height, but since this is not going to be supported anymore, this solution works, where it returns up to 20000 records to be shown at screen. If paging is enabled only pagesize is still visible.
This is where grid will be rendered, so here there is more patches to fix the height problem.
Just an update in the layout so it can be more bootstrap3 compatible in style.
just a small cosmetic update.
There was an error in the first version and also no optimization and it was making the $watch go crazy on large data changes. All data has been fixed in this version.

Now you can resize and all content still fits screen.
Cosmetics update in the code.
just a semi-colon that has been added
@roblarsen
Copy link
Copy Markdown
Contributor

This is... a bit complex. Can you refocus your changes to just target the specific issue? I can't do anything with this many commits, many of which look unrelated.

Also, base any PRs on this issue on 2.0.8

@roblarsen roblarsen closed this Mar 22, 2014
@getuliojr
Copy link
Copy Markdown
Author

Sorry, but i wasn't looking To make a PR because it is listed that it is not been accepted anymore. If will be a 2.08 I can reorganize it for 2.08 problems. Will be such a release ?

@AlJohri
Copy link
Copy Markdown

AlJohri commented May 17, 2014

+1

@getuliojr did you get a chance to look at the HTML here?

@ackimwilliams
Copy link
Copy Markdown

This issue was not addressed. I am still experiencing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants