This repository was archived by the owner on Sep 8, 2020. It is now read-only.
fix #38 while keep compatibility with angular 1.2#40
Closed
llafuente wants to merge 2 commits intoangular-ui:masterfrom
llafuente:master
Closed
fix #38 while keep compatibility with angular 1.2#40llafuente wants to merge 2 commits intoangular-ui:masterfrom llafuente:master
llafuente wants to merge 2 commits intoangular-ui:masterfrom
llafuente:master
Conversation
Author
|
The second commit shouldn't be here, but #36 (29 days...) isn't merged yet and I need something stable to work. I could create a new PR or delete the last commit if you need it. |
Contributor
|
@llafuente Apologies for not having merged this for you back then, but rest assured this issue (#38) will be resolved soon. The reason I haven't merged it yet is there is a big release coming that addresses this issue, as well as many others. It should be out by sometime next week after the unit tests are all finished up and a few final bugs are squashed. Here is a working example with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.