This repository was archived by the owner on Sep 20, 2019. It is now read-only.
fix(null checks): Better Null checking #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmccready
force-pushed
the
1.X
branch
2 times, most recently
from
caf8389 to
6bb1eb6
Compare
nmccready
commented
Sep 17, 2016
| var _getObjectValue = function (object, path){ | ||
| if(!object) return; | ||
| path = path.split('.'); | ||
| var obj = object[path.shift()]; |
Contributor
Author
There was a problem hiding this comment.
Using while and shift should be quicker then forcibly iterating through everything via forEach.
…rols.layers.visible'
nmccready
commented
Sep 17, 2016
| var _controlLayersMustBeVisible = function(baselayers, overlays, mapId) { | ||
| var defaults = leafletMapDefaults.getDefaults(mapId); | ||
| if(!defaults.controls.layers.visible) { | ||
| if(!get(defaults, 'controls.layers.visible')) { |
Contributor
Author
There was a problem hiding this comment.
This kinda stuff is where I much prefer coffeescript... anyway using get to get a value as undefined regardless how nested.
nmccready
commented
Sep 17, 2016
Contributor
Author
nmccready
left a comment
nmccready
left a comment
There was a problem hiding this comment.
There were undefined errors happening against defaults.controls . These changes resolve that.
Contributor
Author
Contributor
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.