This repository was archived by the owner on May 25, 2019. It is now read-only.
Fix event binding edge case#1
Merged
ProLoser merged 1 commit intoangular-ui:masterfrom Apr 16, 2013
Merged
Conversation
inside an ng-repeat, when the collection is empty the watch still gets triggered, but with undefined as value. We shouldn't bind events in this case.
Member
|
I'm merging this for now as I need to do a slight refactor to this repo. Do you think you can add some unit tests that show what you were fixing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inside an ng-repeat, when the collection is empty the watch still gets triggered, but with undefined as value. We shouldn't bind events in this case.