Production rollup bundle target and lite-server target for serving it#58
Production rollup bundle target and lite-server target for serving it#58alexeagle merged 2 commits intoangular:masterfrom gregmagolan:rollup-and-lite-server
Conversation
| this JS resource would be served from a static file. | ||
| --> | ||
| <script src="/bundle.js"></script> | ||
| <script src="/bundle.min.js"></script> |
There was a problem hiding this comment.
One potential issue with this is that when the ts_devserver is serving this file, the bundle is not minified. Calling the script "bundle.min.js" could give readers the wrong idea about what goes on in the ts_devserver case.
There was a problem hiding this comment.
@alexeagle and I discussed this and it's not ideal but I didn't want to use a different html file for the lite-server. Could run the html file through a template but that's another level of complication.
README.md
Outdated
| npm run rollup | ||
| ``` | ||
|
|
||
| Test the bundled rollup application by running `npm run lite-server` |
There was a problem hiding this comment.
I would also include the Bazel versions of the commands in this section, not just the npm run aliases. The first time I read this, I was confused because I assumed these npm run commands were circumventing Bazel entirely. Only when I saw package.json did I realize the npm commands were aliases to Bazel commands.
There was a problem hiding this comment.
Sure. I'll just change the README to show to bazel build commands
|
Fixing the conflicts |
|
Conflicts fixed |
3 participants
No description provided.