This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Update deps & added benchmark to CI#66
Merged
alexeagle merged 5 commits intoangular:masterfrom Jan 26, 2018
gregmagolan:benchmark-and-deps
Merged
Update deps & added benchmark to CI#66alexeagle merged 5 commits intoangular:masterfrom gregmagolan:benchmark-and-deps
alexeagle merged 5 commits intoangular:masterfrom
gregmagolan:benchmark-and-deps
Conversation
…r 5.2.2 and latest rules_nodejs and rules_typescript.
… is passed to bazel
alexeagle
reviewed
Jan 26, 2018
test/e2e/app.spec.ts
Outdated
|
|
||
| describe('angular example application', () => { | ||
| beforeAll(function(done) { | ||
| setTimeout(done, 20000); |
Contributor
There was a problem hiding this comment.
there has to be a better answer.
we have
getPageTimeout: 60 * 1000,
allScriptsTimeout: 60 * 1000,
in protractor.conf.js, but I guess this is not enough. Do we need some help from @vikerman ?
…ow. Wait for server to start before running protractor.
Contributor
Author
|
Fixed the xvfb e2e test. Waiting on the http server to start before running protractor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added @bazel/benchmark-runner and CI benchmark run. Updated to angular 5.2.2 and latest rules_nodejs and rules_typescript.