Skip to content

feat: add file system utilities for 'upgrade' process#1088

Merged
alxhub merged 1 commit intoangular:masterfrom
ashoktamang:fs-utils
Jun 22, 2016
Merged

feat: add file system utilities for 'upgrade' process#1088
alxhub merged 1 commit intoangular:masterfrom
ashoktamang:fs-utils

Conversation

@ashoktamang
Copy link
Copy Markdown
Contributor

'fs-promise.ts' is a utility file for asynchronous read/write operations
'change.ts' implements some change interfaces as specified by the upgrade design doc linked below:
https://github.com/hansl/angular-cli/blob/7ea3e78ff3d899d5277aac5dfeeece4056d0efe3/docs/design/upgrade.md

Comment thread addon/ng2/utilities/change.ts Outdated
/**
* True on success, false otherwise.
*/
apply(): Promise<void>;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation should be 2 spaces per block scope.

@ashoktamang ashoktamang force-pushed the fs-utils branch 3 times, most recently from ff41e29 to 663e6bb Compare June 16, 2016 19:34
@filipesilva filipesilva assigned filipesilva and alxhub and unassigned filipesilva Jun 17, 2016
* Will remove text from the source code.
*/
export class RemoveChange implements Change {
const order: number;
Copy link
Copy Markdown
Member

@alxhub alxhub Jun 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's a duplicate of the constructor parameter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants