feat(@schematics/angular): remove useless import for Ivy

[cexbrayat]

Using cli 6.2.0-beta.2 with the new experimentalIvy flag leads to:

ERROR in src/app/app.module.ts(1,1): error TS6133: 'BrowserModule' is declared but its value is never read.

[alan-agius4]

I think there is the same problem for AppRoutingModule, as at the moment it looks like this is only being used if it's not experimentalIvy

angular-cli/packages/schematics/angular/application/other-files/app.module.ts

Lines 11 to 13 in 151a0b2

	imports: [<% if (!experimentalIvy) { %>
	BrowserModule<% if (routing) { %>,
	AppRoutingModule<% } %>

I think that AppRoutingModule shouldn't be effect by the fact if experimentalIvy is enabled or disabled.

That said, maybe @hansl can confirm about this, as he initial working on implementing the experimentalIvy support

[cexbrayat]

You're right. I generated it without the routing flag so I didn't see it, but I can add it if @hansl confirms.

[hansl]

Yes. I don't even know if we support router in Ivy.

[cexbrayat]

I amended the commit to remove the AppRoutingModule if the experimentalIvy flag is used.

[alexeagle]

We should not promote unused variable to a compiler error. Do we have --noUnusedLocals in the tsconfig? Could we remove that please?

[cexbrayat]

@alexeagle no worries, it's not in the default tsconfig. Sorry if my description was misleading: I just wanted to point out that the useless imports should be removed.

[vikerman]

Rerunning failed tests...

[vikerman]

Please assign appropriate merge target

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}