fix(@angular-devkit/build-angular): improve webpack loader resolution#13687
Merged
kyliau merged 1 commit intoangular:masterfrom Feb 19, 2019
Merged
fix(@angular-devkit/build-angular): improve webpack loader resolution#13687kyliau merged 1 commit intoangular:masterfrom
kyliau merged 1 commit intoangular:masterfrom
Conversation
clydin
force-pushed
the
fix-pnpm
branch
2 times, most recently
from
04e17f2 to
4be57b5
Compare
filipesilva
suggested changes
Feb 18, 2019
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
I think the changes themselves look fine but the size test says polyfills has increased by 41kb. That's odd because these changes shouldn't affect bundle size. Can you take a look?
Previously, all loaders either needed to be in the workspace's node modules directory or a node modules directory directly within the build angular package. A package manager can potentially hoist a loader to a node modules location inbetween the two and causing loader resolution to fail. This change causes webpack to check all intermediate node modules directories in addition to the initial two locations.
Member
Author
|
Size check was unrelated to this PR. |
filipesilva
approved these changes
Feb 18, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all loaders either needed to be in the workspace's node modules directory or a node modules directory directly within the build angular package. A package manager can potentially hoist a loader to a node modules location inbetween the two and cause loader resolution to fail. This change causes webpack to check all intermediate node modules directories in addition to the initial two locations.
Partial fix for #13680