fix(@angular-devkit/benchmark): Allows the CLI repo to be hosted in a directory with spaces.#16073
Merged
mgechev merged 1 commit intoangular:masterfrom Nov 8, 2019
Merged
fix(@angular-devkit/benchmark): Allows the CLI repo to be hosted in a directory with spaces.#16073mgechev merged 1 commit intoangular:masterfrom
mgechev merged 1 commit intoangular:masterfrom
Conversation
filipesilva
approved these changes
Nov 6, 2019
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
I don't remember why I added shell: true there. If it passes, then LGTM!
filipesilva
added
the
target: patch
Collaborator
|
Nit: the commit message scope should be |
… directory with spaces. child_process.spawn() with `shell: true` does not quote its arguments, so any data passed in must be surrounded by quotes to properly include spaces. This was making tests fail when the repository is checked out to a directory with a space in it. Easiest solution is to simply not use shell escaping which avoids the whole problem.
dgp1130
changed the title
Collaborator
Author
|
Updated the commit and PR name to use I didn't see that option in the list of scopes doc, is that an oversight or are there more allowed scopes than are listed there? |
Collaborator
|
I guess, it's not listed because it's a private package. |
mgechev
pushed a commit
that referenced
this pull request
Nov 8, 2019
… directory with spaces. (#16073) child_process.spawn() with `shell: true` does not quote its arguments, so any data passed in must be surrounded by quotes to properly include spaces. This was making tests fail when the repository is checked out to a directory with a space in it. Easiest solution is to simply not use shell escaping which avoids the whole problem.
dgp1130
added a commit
to dgp1130/angular-cli
that referenced
this pull request
Nov 8, 2019
…ted in a directory with spaces. (angular#16073)" This reverts commit 217eb29. Reverting as this is breaking some Windows/CI builds. See angular#16119.
This was referenced Nov 14, 2019
Closed
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
child_process.spawn()withshell: truedoes not quote its arguments, so any data passed in must be surrounded by quotes to properly include spaces (nodejs/node#5060). This was making tests fail when the repository is checked out to a directory with a space in it.Easiest solution is to simply not use shell escaping which avoids the whole problem.
Alternatively, we could attempt to wrap every argument in quotes, but that would require escaping any existing quotes, which could cause other problems. In the original PR for this file, I don't see a strong motivation for using
shell: true, and all the tests pass without it, so I think the best solution is to just remove this flag.