fix(@angular/pwa): use relative paths in webmanifest#17075
Merged
dgp1130 merged 1 commit intoangular:masterfrom Feb 25, 2020
cyrilletuzi:pwamanifestrelativepaths
Merged
fix(@angular/pwa): use relative paths in webmanifest#17075dgp1130 merged 1 commit intoangular:masterfrom cyrilletuzi:pwamanifestrelativepaths
dgp1130 merged 1 commit intoangular:masterfrom
cyrilletuzi:pwamanifestrelativepaths
Conversation
This was referenced Feb 25, 2020
clydin
approved these changes
Feb 25, 2020
Collaborator
|
Also merged to 9.0.x patch branch. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use relative paths instead of absolute paths in
manifest.webmanifest, so PWA (including the service worker) can work with apps withbase-hrefdifferent from just/. It's especially important since Angular CLI v9 as the new--localizeoption usesbase-hrefvalues different from just/.Fixes #16922
Fixes #15092