feat(Docs): documentation for 'ng install'. Table of Contents for README #173
Conversation
|
Nice job @NathanWalker, thanks. |
docs/ng-install.md
Outdated
| 2. Copy/paste this subject: `Please add a default export to support angular-cli auto install feature` | ||
| 3. Copy/paste this message for the body: | ||
|
|
||
| > It would be great if this library provided a `default` export object as described [here in the angular-cli Publisher's Guide](https://github.com/angular/angular-cli). Our project would greatly benefit from it and it's very easy to do. Please comment back if that would be possible. If you won't have time in the next couple days, I will try to submit a PR to provide this compatibility soon. Thank you! |
There was a problem hiding this comment.
This should link to https://github.com/angular/angular-cli/blob/master/docs/ng-install.md##b-publisher-guide-preparing-your-library, I think.
There was a problem hiding this comment.
Thanks @filipesilva good catch, fix coming.
|
Added two comments but it has my lgtm anyway. Concise, well written and very complete. Great job @NathanWalker . |
|
@filipesilva I'll squash the commits once @jkuri and I make a conclusion on your other comment, thanks. |
|
Nathan you can skip styleUrls for now. On Thursday, 4 February 2016, Nathan Walker notifications@github.com
|
|
@jkuri It's better to leave it, I think. There is no problem with it, I just wanted to understand it's function better. |
|
I'm ready to merge once it's squashed. |
|
Squashed and ready. Thanks @filipesilva! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
No description provided.