fix(@ngtools/webpack): getCanonicalFileName should return FS compatible paths#17692
Merged
clydin merged 1 commit intoangular:masterfrom May 12, 2020
alan-agius4:ngtools-canonical
Merged
fix(@ngtools/webpack): getCanonicalFileName should return FS compatible paths#17692clydin merged 1 commit intoangular:masterfrom alan-agius4:ngtools-canonical
clydin merged 1 commit intoangular:masterfrom
alan-agius4:ngtools-canonical
Conversation
alan-agius4
added
the
target: patch
Collaborator
Author
|
//CC @JoostK and @petebacondarwin. |
clydin
approved these changes
May 11, 2020
…le paths Unlike TSC which has it's own mechanism the resolve and join paths in POSIX format, NGTSC heavily relies onNode.JS `fs` and `path` modules. This prevents `Path` usage because in Windows `path.resolve` will causes an absolute path to be resolved or joined incorrectly. Example: `/D/MyPath/MyProject` -> `D:/d/mypath/myproject`. With this change we change the `getCanonicalFileName` method to return FS compatible paths.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike TSC which has it's own mechanism the resolve and join paths in POSIX format, NGTSC heavily relies onNode.JS
fsandpathmodules. This preventsPathusage because in Windowspath.resolvewill causes an absolute path to be resolved or joined incorrectly. Example:/D/MyPath/MyProject->D:/d/mypath/myproject.With this change we change the
getCanonicalFileNamemethod to return FS compatible paths.