Tslib 2.0 changes#17759
Merged
filipesilva merged 3 commits intoangular:masterfrom May 20, 2020
alan-agius4:tslib-2.0-changes
Merged
Tslib 2.0 changes#17759filipesilva merged 3 commits intoangular:masterfrom alan-agius4:tslib-2.0-changes
filipesilva merged 3 commits intoangular:masterfrom
alan-agius4:tslib-2.0-changes
Conversation
alan-agius4
added
the
target: major
SchnWalter
reviewed
May 19, 2020
clydin
requested changes
May 19, 2020
IgorMinar
reviewed
May 19, 2020
Contributor
IgorMinar
left a comment
IgorMinar
left a comment
There was a problem hiding this comment.
this looks roughly right to me, but I'll defer to @clydin on this one. thanks @alan-agius4 for putting this together.
clydin
approved these changes
May 19, 2020
Webpack relies on package managers to do module hoisting and doesn't have any deduping logic since version 4. However relaying on package manager has a number of short comings, such as when having the same library with the same version laid out in different parts of the node_modules tree. Example: ``` /node_modules/tslib@2.0.0 /node_modules/library-1/node_modules/tslib@1.0.0 /node_modules/library-2/node_modules/tslib@1.0.0 ``` In the above case, in the final bundle we'll end up with 3 versions of tslib instead of 2, even though 2 of the modules are identical. Webpack has an open issue for this webpack/webpack#5593 (Duplicate modules - NOT solvable by `npm dedupe`) With this change we add a custom resolve plugin that dedupes modules with the same name and versions that are laid out in different parts of the node_modules tree.
TypeScript 3.9 requires tslib 2.0.0, with this change we; - Update tslib existing and new workspaces to use tslib 2.0.0 - Update new and existing libraries to use tslib 2.0.0 as a direct depedency. Tslib version is bound to the TypeScript version used to compile the library. Thus, we shouldn't list `tslib` as a `peerDependencies`. This is because, a user can install libraries which have been compiled with older versions of TypeScript and thus require multiple `tslib` versions to be installed. Closes: #17753 Reference: TOOL-1374
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.