refactor(@angular-devkit/build-angular): mention how to disable the w…#17802
Merged
clydin merged 1 commit intoangular:masterfrom May 28, 2020
Merged
refactor(@angular-devkit/build-angular): mention how to disable the w…#17802clydin merged 1 commit intoangular:masterfrom
clydin merged 1 commit intoangular:masterfrom
Conversation
alan-agius4
reviewed
May 27, 2020
alan-agius4
added
the
action: cleanup
cexbrayat
force-pushed
the
refactor/commonjs-warning
branch
from
298a880 to
8af3965
Compare
alan-agius4
reviewed
May 28, 2020
…arning for commonjs dependencies The current message clearly mentions which dependencies are CommonJS ones, but doesn't point out how to get rid of the warning if nothing can be done. This commit adds a mention of `allowedCommonJsDependencies` in the warning to help developers (as we do for `versionMismatch` for example).
cexbrayat
force-pushed
the
refactor/commonjs-warning
branch
from
8af3965 to
1630982
Compare
alan-agius4
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…arning for commonjs dependencies
The current message clearly mentions which dependencies are CommonJS ones, but doesn't point out how to get rid of the warning if nothing can be done. This commit adds a mention of
allowedCommonJsDependenciesin the warning to help developers (as we do forversionMismatchfor example).