Skip to content

refactor: remove path mappings from NgccProcessor#17896

Merged
filipesilva merged 1 commit intoangular:masterfrom
alan-agius4:refactor-ngcc-path-mappings
Jun 10, 2020
Merged

refactor: remove path mappings from NgccProcessor#17896
filipesilva merged 1 commit intoangular:masterfrom
alan-agius4:refactor-ngcc-path-mappings

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 commented Jun 10, 2020

Path mappings are now inferred from the provided tsconfig.json, thus it's now redundant to provide them.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 10, 2020
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
There is a typo in the commit message: ffrom.

Path mappings are now inferred from the provided `tsconfig.json`, thus it's now redundant to provide them.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 10, 2020
@filipesilva filipesilva merged commit 1f04bf7 into angular:master Jun 10, 2020
@alan-agius4 alan-agius4 deleted the refactor-ngcc-path-mappings branch June 10, 2020 19:27
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants