fix(@schematics/angular): validate project name before prompts#17949
Merged
alan-agius4 merged 1 commit intoangular:masterfrom Jul 7, 2020
Merged
Conversation
When an invalid project name is given, throw an error before going through prompts. Closes angular#14994
14 tasks
alan-agius4
added
the
target: patch
alan-agius4
approved these changes
Jul 7, 2020
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
LGTM, thanks for this 👍
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an invalid project name is given, throw an error before going through prompts.
I'm not sure if this validation can be removed but let me know if it should: https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/application/index.ts#L335
Closes #14994