test(@schematics/schematics): run npm install from local registry#18199
Merged
alan-agius4 merged 1 commit intoangular:masterfrom Jul 9, 2020
Merged
test(@schematics/schematics): run npm install from local registry#18199alan-agius4 merged 1 commit intoangular:masterfrom
alan-agius4 merged 1 commit intoangular:masterfrom
Conversation
kyliau
force-pushed
the
e2e-local-registry
branch
from
e8d2c40 to
a77edc9
Compare
kyliau
changed the title
alan-agius4
requested changes
Jul 9, 2020
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
The commit type should be test: since this only effects e2e tests.
After a new tag is pushed, the schematic e2e test will attempt to install the latest version, but it incorrectly installs the version from the actual NPM registry instead of the local registry.
kyliau
force-pushed
the
e2e-local-registry
branch
from
a77edc9 to
4222e4d
Compare
kyliau
changed the title
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a new tag is pushed, the schematic e2e test will attempt to
install the latest version, but it incorrectly installs the version
from the actual NPM registry instead of the local registry.