fix(@schematics/angular): consecutive blank lines in routing.module.ts

[sacgrover]

Fixes: #18220

[alan-agius4]

Hi @sacgrover,

Thanks for this, however I think the proper fix would be something like the below, as otherwise when there is the import for the component file there wouldn't be a blank line between the import and the const declaration.

import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';<% if (lazyRoute) { %>
import { <%= classify(name) %>Component } from './<%= dasherize(name) %>.component';<% } %>

const routes: Routes = [<% if (lazyRoute) { %>{ path: '', component: <%= classify(name) %>Component }<% } %>];

[sacgrover]

@alan-agius4 Ok, I will do that.. Actually, I made the same earlier but to make it consistent with other I modified. Because there are a blank line between module import and component import in other places.
like this https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/application/other-files/app.module.ts.template#L5

[alan-agius4]

@sacgrover, I see, in that case there should be a blank line in the logical statement and before the constant declaration.

import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';<% if (lazyRoute) { %>

import { <%= classify(name) %>Component } from './<%= dasherize(name) %>.component';<% } %>

const routes: Routes = [<% if (lazyRoute) { %>{ path: '', component: <%= classify(name) %>Component }<% } %>];

[sacgrover]

Changes done as per asked.
Seems like it got failed without any reason. It needs to get rerun. Could you please do that?

[alan-agius4]

LGTM, thanks

[ngbot]

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci/angular: size" is failing
     status "ci/circleci: e2e-cli" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[sacgrover]

LGTM, thanks

Could You please rerun it as i don't have permissions for it?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}