Skip to content

fix(@schematics/schematics): await expect result in full schematic test#18406

Merged
alan-agius4 merged 1 commit intoangular:10.0.xfrom
alan-agius4:async-fix-schematic-schematic-test
Jul 30, 2020
Merged

fix(@schematics/schematics): await expect result in full schematic test#18406
alan-agius4 merged 1 commit intoangular:10.0.xfrom
alan-agius4:async-fix-schematic-schematic-test

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

(cherry picked from commit 56c5bce)

@googlebot

This comment has been minimized.

@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label Jul 30, 2020
@alan-agius4 alan-agius4 requested a review from clydin July 30, 2020 17:49
@clydin
Copy link
Copy Markdown
Member

clydin commented Jul 30, 2020

@googlebot I consent.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2020
@ngbot
Copy link
Copy Markdown

ngbot bot commented Jul 30, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: e2e-cli-ve" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alan-agius4 alan-agius4 merged commit bc7ae0b into angular:10.0.x Jul 30, 2020
@alan-agius4 alan-agius4 deleted the async-fix-schematic-schematic-test branch July 30, 2020 19:26
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants