fix(@angular-devkit/build-angular): add karma as an optional peer dependency#18893
Merged
alan-agius4 merged 4 commits intoangular:masterfrom Sep 25, 2020
Merged
fix(@angular-devkit/build-angular): add karma as an optional peer dependency#18893alan-agius4 merged 4 commits intoangular:masterfrom
alan-agius4 merged 4 commits intoangular:masterfrom
Conversation
…endency karma is currently used by the karma builder within this package but is not represented in the dependencies. The can lead to accidental version mismatches as well as package manager hoisting problems due to the package manager not knowing the full dependency set of the package.
alan-agius4
approved these changes
Sep 25, 2020
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
I think there are also other deps such as tslint, protoactor etc.. but this is a good start!
alan-agius4
approved these changes
Sep 25, 2020
Member
Author
|
added protractor/tslint |
clydin
force-pushed
the
karma-optional-peer
branch
from
73784f8 to
3d4aad0
Compare
…r dependency protractor is currently used by the protractor builder within this package but is not represented in the dependencies. The can lead to accidental version mismatches as well as package manager hoisting problems due to the package manager not knowing the full dependency set of the package.
…endencies rule disabling
…pendency tslint is currently used by the tslint builder within this package but is not represented in the dependencies. The can lead to accidental version mismatches as well as package manager hoisting problems due to the package manager not knowing the full dependency set of the package.
clydin
force-pushed
the
karma-optional-peer
branch
from
3d4aad0 to
a1f9c76
Compare
alan-agius4
approved these changes
Sep 25, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
karma is currently used by the karma builder within this package but is not represented in the dependencies. The can lead to accidental version mismatches as well as package manager hoisting problems due to the package manager not knowing the full dependency set of the package.