Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Sep 30, 2020

Previously, the workspace configuration file was found and loaded by individual commands potentially multiple times. This change moves the initial workspace location discovery and loading of the workspace to the CLI startup. It also provides the workspace to each command so that the commands can reuse the already loaded and parsed workspace configuration.
This change will serve as a base to further refactor and consolidate workspace option usage.

@clydin clydin added the target: major This PR is targeted for the next major release label Sep 30, 2020
@clydin clydin requested a review from alan-agius4 September 30, 2020 15:48
@clydin clydin force-pushed the workspace-object branch 2 times, most recently from 5eabc9b to 019c11c Compare September 30, 2020 18:46
Previously, the workspace configuration file was found and loaded by individual commands potentially multiple times.  This change moves the initial workspace location discovery and loading of the workspace to the CLI startup.  It also provides the workspace to each command so that the commands can reuse the already loaded and parsed workspace configuration.
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2020
@clydin clydin merged commit b2b5367 into angular:master Oct 2, 2020
@clydin clydin deleted the workspace-object branch October 2, 2020 11:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants