fix(@angular-devkit/build-optimizer): set rxjs as having safe side effects#19221
Merged
clydin merged 1 commit intoangular:masterfrom Oct 27, 2020
Merged
fix(@angular-devkit/build-optimizer): set rxjs as having safe side effects#19221clydin merged 1 commit intoangular:masterfrom
clydin merged 1 commit intoangular:masterfrom
Conversation
alan-agius4
approved these changes
Oct 27, 2020
…fects The rxjs package contains module level side effects that are not marked with a pure annotation. However, these side effects are safe to remove if the values are unused.
alan-agius4
force-pushed
the
safe-side-effects-rxjs
branch
from
759e6e5 to
8650f0e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rxjs package contains module level side effects that are not marked with a pure annotation. However, these side effects are safe to remove if the values are unused.