Skip to content

fix(@angular-devkit/build-angular): add console error when using HMR in production mode#19592

Merged
filipesilva merged 1 commit intoangular:masterfrom
alan-agius4:hmr-error-prod
Dec 15, 2020
Merged

fix(@angular-devkit/build-angular): add console error when using HMR in production mode#19592
filipesilva merged 1 commit intoangular:masterfrom
alan-agius4:hmr-error-prod

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

FIx: #19591

@google-cla google-cla bot added the cla: yes label Dec 11, 2020
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 11, 2020
@alan-agius4 alan-agius4 requested a review from clydin December 11, 2020 10:11
Comment thread packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts Outdated
@alan-agius4 alan-agius4 requested a review from clydin December 11, 2020 19:05
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Dec 11, 2020
@filipesilva filipesilva merged commit ba9c755 into angular:master Dec 15, 2020
@alan-agius4 alan-agius4 deleted the hmr-error-prod branch December 15, 2020 12:27
@filipesilva
Copy link
Copy Markdown
Contributor

@alan-agius4 this PR does not apply cleanly to 10.2.x. Can you take a look?

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--hmr with enableProdMode() breaks HMR

3 participants