fix(@schematics/angular): remove unnecessary scripts and dependencies#19639
Merged
alan-agius4 merged 1 commit intomasterfrom Dec 18, 2020
unknown repository
Merged
fix(@schematics/angular): remove unnecessary scripts and dependencies#19639alan-agius4 merged 1 commit intomasterfrom unknown repository
alan-agius4 merged 1 commit intomasterfrom
unknown repository
Conversation
Author
alan-agius4
requested changes
Dec 17, 2020
alan-agius4
added
action: cleanup
When new application is generated with --minimal flag it will be created without any testing frameworks, linters, etc. But package.json still contains broken scripts and dependencies. So "test": "ng test", "lint": "ng lint" and "tslint": "~6.1.0", "ts-node": "~8.3.0" should be removed. By analogy with "e2e": "ng e2e".
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When new application is generated with
--minimalflag it will be created without any testing frameworks, linters, etc. Butpackage.jsonstill contains broken scripts and dependencies. So"test": "ng test","lint": "ng lint"and"tslint": "~6.1.0"should be removed. By analogy with"e2e": "ng e2e".