fix(@angular/cli): direct Angular schematic dependency requests to known versions#19857
Merged
alan-agius4 merged 2 commits intoangular:masterfrom Jan 28, 2021
Merged
Conversation
clydin
force-pushed
the
schematics-rewire-deps
branch
2 times, most recently
from
b30210e to
15a92ab
Compare
alan-agius4
reviewed
Jan 25, 2021
alan-agius4
reviewed
Jan 25, 2021
alan-agius4
reviewed
Jan 25, 2021
clydin
force-pushed
the
schematics-rewire-deps
branch
3 times, most recently
from
2113c81 to
451cc8a
Compare
…kflow engine host This adds an option to the NodeWorkflow to allow a custom NodeModulesEngineHost to be used with the workflow.
…known versions This change adds logic to redirect module resolution requests for Angular schematics to ensure that the correct versions of core schematic related packages are used. This also ensures that the runtime version of the schematics package matches the version used inside the schematic and that object instances passed into the schematic are compatible. The current set of core schematic related packages are `@angular-devkit/*` and `@schematics/angular`. Only first-party Angular schematics are currently affected by this change.
clydin
force-pushed
the
schematics-rewire-deps
branch
from
451cc8a to
a2caf64
Compare
alan-agius4
reviewed
Jan 28, 2021
| /** | ||
| * Minimal shim modules for legacy deep imports of `@schematics/angular` | ||
| */ | ||
| const legacyModules: Record<string, unknown> = { |
Collaborator
There was a problem hiding this comment.
Good call to add a shim
alan-agius4
approved these changes
Jan 28, 2021
15 tasks
Contributor
|
Thank you! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds logic to redirect module resolution requests for Angular schematics to ensure that the correct versions of core schematic related packages are used. This also ensures that the runtime version of the schematics package matches the version used inside the schematic and that object instances passed into the schematic are compatible.
The current set of core schematic related packages are
@angular-devkit/*and@schematics/angular. Only first-party Angular schematics are currently affected by this change.This change also solves issues such as #16392 which were caused by the package manager not hoisting the core schematic packages to a location the update migrations could access.