Skip to content

refactor(@angular-devkit/build-angular): remove usage of Webpack Stats.ToJsonOutput type#20016

Merged
clydin merged 1 commit intoangular:masterfrom
clydin:webpack5/tojsonoutput-removal
Feb 11, 2021
Merged

refactor(@angular-devkit/build-angular): remove usage of Webpack Stats.ToJsonOutput type#20016
clydin merged 1 commit intoangular:masterfrom
clydin:webpack5/tojsonoutput-removal

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Feb 10, 2021

The Stats.ToJsonOutput type is not present in the Webpack 5 typings. There was also a large amount of forced typing in the code to successfully compile.
Minimal Webpack JSON stat types are now used that represent the fields used by the tooling.

@clydin clydin added the target: major This PR is targeted for the next major release label Feb 10, 2021
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
…s.ToJsonOutput type

The `Stats.ToJsonOutput` type is not present in the Webpack 5 typings. There was also a large amount of forced typing in the code to successfully compile.
Minimal Webpack JSON stat types are now used that represent the fields used by the tooling.
@clydin clydin force-pushed the webpack5/tojsonoutput-removal branch from bb2b492 to 6dff7d1 Compare February 10, 2021 18:14
@clydin clydin requested a review from alan-agius4 February 10, 2021 18:41
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 11, 2021
@clydin clydin merged commit 40dc44b into angular:master Feb 11, 2021
@clydin clydin deleted the webpack5/tojsonoutput-removal branch February 11, 2021 17:33
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants