Skip to content

perf(@angular-devkit/build-angular): remove Webpack Stats.toJson usage in analytics plugin#20267

Merged
alan-agius4 merged 1 commit intoangular:masterfrom
clydin:webpack-plugin/perf-webpack-stats-3
Mar 15, 2021
Merged

perf(@angular-devkit/build-angular): remove Webpack Stats.toJson usage in analytics plugin#20267
alan-agius4 merged 1 commit intoangular:masterfrom
clydin:webpack-plugin/perf-webpack-stats-3

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Mar 14, 2021

Webpack's Stats.toJson function is an expensive operation and is recommended to be avoided where possible. In the case of the analytics plugin, the chunks and assets can be accessed directly from the Webpack compilation.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Mar 14, 2021
@google-cla google-cla bot added the cla: yes label Mar 14, 2021
…e in analytics plugin

Webpack's Stats.toJson function is an expensive operation and is recommended to be avoided where possible. In the case of the analytics plugin, the chunks and assets can be accessed directly from the Webpack compilation.
@clydin clydin force-pushed the webpack-plugin/perf-webpack-stats-3 branch from 7119944 to ed87302 Compare March 14, 2021 19:31
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2021
@alan-agius4 alan-agius4 merged commit 3affd28 into angular:master Mar 15, 2021
@clydin clydin deleted the webpack-plugin/perf-webpack-stats-3 branch March 15, 2021 11:37
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants