Skip to content

fix(@schematics/angular): set inlineStyleLanguage when application style option is used#20542

Merged
alan-agius4 merged 2 commits intoangular:masterfrom
clydin:inline-resources/ng-new-style
Apr 19, 2021
Merged

fix(@schematics/angular): set inlineStyleLanguage when application style option is used#20542
alan-agius4 merged 2 commits intoangular:masterfrom
clydin:inline-resources/ng-new-style

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Apr 15, 2021

The style option for the application schematic specifies the language/preprocessor to use for the application's external style files and should also setup the default for inline styles as well via the inlineStyleLanguage build option. The value can be adjusted after application generation if needed.

clydin added 2 commits April 15, 2021 09:58
…`style` option is used

The `style` option for the application schematic specifies the language/preprocessor to use for the application's external style files and should also setup the default for inline styles as well via the `inlineStyleLanguage` build option. The value can be adjusted after application generation if needed.
…present in build options

The `inlineStyleLanguage` option should be set for an application's server target if also present in the application's build target. The setting is needed to ensure the server target properly builds the applica
tion's styles.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Apr 15, 2021
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
@clydin clydin requested a review from alan-agius4 April 15, 2021 15:53
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 16, 2021
@alan-agius4 alan-agius4 merged commit 18c8adf into angular:master Apr 19, 2021
@clydin clydin deleted the inline-resources/ng-new-style branch April 19, 2021 18:31
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants