Skip to content

fix(@angular/cli): propagate update's force option to package managers#20703

Merged
filipesilva merged 2 commits intoangular:masterfrom
clydin:update-npm7-force
May 10, 2021
Merged

fix(@angular/cli): propagate update's force option to package managers#20703
filipesilva merged 2 commits intoangular:masterfrom
clydin:update-npm7-force

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented May 5, 2021

When the CLI update command's --force option is used, the underlying package manager will also be executed with its force option. This behavior is especially important with the advent of npm 7 which will fail installation if any peer dependency version ranges are mismatched.

@clydin clydin added the target: rc This PR is targeted for the next release-candidate label May 5, 2021
@google-cla google-cla bot added the cla: yes label May 5, 2021
clydin added 2 commits May 6, 2021 09:22
…s force option

This change allows consumers of the `NodeWorkflow` to configure the package installation task to use a package manager's `--force` option. This will be used by the `@angular/cli` update command when the update command's force option is used. This change is not intended to enable a schematic to adjust the force option.
When the CLI update command's `--force` option is used, the underlying package manager will also be executed with its force option. This behavior is especially important with the advent of npm 7 which will fail installation if any peer dependency version ranges are mismatched.
@clydin clydin force-pushed the update-npm7-force branch from ee030f8 to af54bef Compare May 6, 2021 13:22
@clydin clydin requested a review from alan-agius4 May 6, 2021 18:01
Copy link
Copy Markdown

@lodenrogue lodenrogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to select one and not the other?

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 7, 2021
@filipesilva filipesilva merged commit 3d8c16a into angular:master May 10, 2021
@clydin clydin deleted the update-npm7-force branch May 10, 2021 15:22
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants