test: use correct snapshot versions in add-pwa E2E test with yarn#20956
Merged
clydin merged 1 commit intoangular:masterfrom May 26, 2021
Merged
test: use correct snapshot versions in add-pwa E2E test with yarn#20956clydin merged 1 commit intoangular:masterfrom
clydin merged 1 commit intoangular:masterfrom
Conversation
When executing the add-pwa E2E test with Angular snapshots, the package versions need to be updated after the `ng add @angular/pwa` call to ensure that the correct version of `@angular/service-worker` is used. Yarn requires a different package installation strategy due to Yarn not always installing a new version of a github sha when directly adding an individual package.
alan-agius4
approved these changes
May 26, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing the add-pwa E2E test with Angular snapshots, the package versions need to be updated after the
ng add @angular/pwacall to ensure that the correct version of@angular/service-workeris used.Yarn requires a different package installation strategy due to Yarn not always installing a new version of a github sha when directly adding an individual package.